iotex-core icon indicating copy to clipboard operation
iotex-core copied to clipboard

[api] verify received tx hash is correct

Open dustinxie opened this issue 1 year ago • 2 comments

Description

small clean-up to better the test

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [x] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

dustinxie avatar Jan 29 '24 23:01 dustinxie

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.32%. Comparing base (e1f0636) to head (8eaa2f5). Report is 173 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4074      +/-   ##
==========================================
+ Coverage   75.38%   76.32%   +0.94%     
==========================================
  Files         303      339      +36     
  Lines       25923    28868    +2945     
==========================================
+ Hits        19541    22034    +2493     
- Misses       5360     5729     +369     
- Partials     1022     1105      +83     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 29 '24 23:01 codecov[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
4.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Feb 22 '24 20:02 sonarqubecloud[bot]