iotex-core icon indicating copy to clipboard operation
iotex-core copied to clipboard

[contractstaking] check file fingerprint

Open dustinxie opened this issue 1 year ago • 2 comments

Description

provides a func to check the contractstaking indexer DB file fingerprint

see #3924 which fixes #3921. Mainnet does not contain any buggy tx that would trigger #3921, the PR is used to verify that contractstaking.indexer.db generated by v1.11.1-rc0 (which contains fix #3924) is identical to that generated by current v1.11.0

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [x] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x] make test
  • [] fullsync
  • [] Other test (please specify)

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

dustinxie avatar Aug 22 '23 00:08 dustinxie

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Aug 22 '23 03:08 sonarqubecloud[bot]

Codecov Report

Merging #3925 (b3c0115) into master (e1f0636) will increase coverage by 0.53%. Report is 81 commits behind head on master. The diff coverage is 72.17%.

:exclamation: Current head b3c0115 differs from pull request most recent head 358171c. Consider uploading reports for the commit 358171c to get more accurate results

@@            Coverage Diff             @@
##           master    #3925      +/-   ##
==========================================
+ Coverage   75.38%   75.91%   +0.53%     
==========================================
  Files         303      328      +25     
  Lines       25923    27893    +1970     
==========================================
+ Hits        19541    21174    +1633     
- Misses       5360     5626     +266     
- Partials     1022     1093      +71     
Files Changed Coverage Δ
action/protocol/execution/evm/evm.go 43.52% <0.00%> (-2.95%) :arrow_down:
action/protocol/execution/evm/evmstatedbadapter.go 66.77% <ø> (ø)
action/protocol/poll/consortium.go 0.00% <0.00%> (ø)
action/protocol/poll/staking_committee.go 43.85% <0.00%> (ø)
...tion/protocol/staking/contractstake_bucket_type.go 0.00% <0.00%> (ø)
action/receipt.go 82.17% <ø> (ø)
api/grpcserver.go 86.40% <0.00%> (ø)
api/loglistener.go 25.00% <0.00%> (ø)
api/websocket.go 4.10% <0.00%> (-1.07%) :arrow_down:
blockchain/config.go 74.54% <ø> (ø)
... and 65 more

... and 5 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 22 '23 03:08 codecov[bot]