iotex-core icon indicating copy to clipboard operation
iotex-core copied to clipboard

[ioctl] Build Read unittest

Open LuckyPigeon opened this issue 2 years ago • 4 comments

Description

Build Read unittest for action command

refer to #3444 & #3472

Type of change

Please delete options that are not relevant.

  • [x] Code refactor or improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x] make test
  • [x] TestRead

Test Configuration:

  • Firmware version: Windows 10 (WSL Version: Ubuntu 18.04)
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

LuckyPigeon avatar Sep 10 '22 01:09 LuckyPigeon

Codecov Report

Merging #3635 (102e93a) into master (e9732a1) will decrease coverage by 0.32%. The diff coverage is 77.90%.

@@            Coverage Diff             @@
##           master    #3635      +/-   ##
==========================================
- Coverage   74.95%   74.63%   -0.33%     
==========================================
  Files         269      264       -5     
  Lines       23819    23687     -132     
==========================================
- Hits        17854    17679     -175     
- Misses       5039     5080      +41     
- Partials      926      928       +2     
Impacted Files Coverage Δ
db/trie/mptrie/node.go 100.00% <ø> (ø)
ioctl/newcmd/action/action.go 79.62% <ø> (+0.09%) :arrow_up:
ioctl/newcmd/node/nodedelegate.go 70.19% <0.00%> (-0.95%) :arrow_down:
ioctl/newcmd/node/nodeprobationlist.go 90.90% <0.00%> (-4.33%) :arrow_down:
action/protocol/execution/evm/evm.go 44.57% <26.66%> (-0.86%) :arrow_down:
db/trie/mptrie/hashnode.go 36.36% <41.17%> (-54.55%) :arrow_down:
db/trie/mptrie/merklepatriciatrie.go 78.73% <46.80%> (-12.70%) :arrow_down:
db/trie/mptrie/leafiterator.go 62.06% <50.00%> (ø)
action/protocol/execution/evm/evmstatedbadapter.go 65.87% <64.28%> (-0.04%) :arrow_down:
db/trie/mptrie/extensionnode.go 89.89% <94.28%> (-3.09%) :arrow_down:
... and 13 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 10 '22 01:09 codecov[bot]

@LuckyPigeon I delete the useless codes and variable. so the codes seems clearly.

huof6829 avatar Sep 21 '22 02:09 huof6829

@huof6829 Thanks for the help, I'll do the same change on #3631

LuckyPigeon avatar Sep 21 '22 02:09 LuckyPigeon

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.7% 3.7% Duplication

sonarqubecloud[bot] avatar Sep 30 '22 01:09 sonarqubecloud[bot]