iotex-core icon indicating copy to clipboard operation
iotex-core copied to clipboard

events for node

Open millken opened this issue 2 years ago • 3 comments

Description

Fixes #3204

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

millken avatar Sep 09 '22 07:09 millken

Codecov Report

Merging #3634 (1b1944d) into master (263ff82) will increase coverage by 0.60%. The diff coverage is 81.32%.

@@            Coverage Diff             @@
##           master    #3634      +/-   ##
==========================================
+ Coverage   74.47%   75.07%   +0.60%     
==========================================
  Files         269      299      +30     
  Lines       23925    25202    +1277     
==========================================
+ Hits        17818    18921    +1103     
- Misses       5174     5302     +128     
- Partials      933      979      +46     
Impacted Files Coverage Δ
action/actctx.go 90.62% <ø> (+6.25%) :arrow_up:
action/action.go 82.35% <ø> (ø)
action/action_deserializer.go 57.14% <ø> (ø)
action/candidate_update.go 88.88% <0.00%> (-4.14%) :arrow_down:
action/consignment_transfer.go 90.41% <ø> (ø)
action/const.go 100.00% <ø> (ø)
action/execution.go 83.78% <ø> (ø)
action/grantreward.go 68.57% <ø> (ø)
action/protocol/account/protocol.go 86.90% <ø> (ø)
action/protocol/account/transfer.go 84.61% <ø> (ø)
... and 276 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 09 '22 07:09 codecov[bot]

how does this pr solve #3204 ?

Liuhaai avatar Sep 09 '22 17:09 Liuhaai

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
5.0% 5.0% Duplication

sonarqubecloud[bot] avatar Oct 31 '22 08:10 sonarqubecloud[bot]

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.5% 3.5% Duplication

sonarqubecloud[bot] avatar Jan 13 '23 05:01 sonarqubecloud[bot]