Description

Refactor jwtsign command in new ioctl, with the following note.

Use client interface to construct the Cobra command.
Output package is deprecated, replace it with errors package.
Replace fmt.Println with cmd.Println
Refactor unit test to cover the modification.

Fixes #3287

Type of change

Please delete options that are not relevant.

[x] Code refactor or improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] make test
[x] TestNewJwtSignCmd

Test Configuration:

Firmware version: Ubuntu 21.04
Hardware:
Toolchain:
SDK:

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Jul 18 '22 16:07 LuckyPigeon

@huof6829 The unittest need to add signer flag, but signer flag is a private utility inside action package, how can I get access to it?

Jul 18 '22 16:07 LuckyPigeon

Codecov Report

Merging #3561 (561e7e2) into master (a20e489) will decrease coverage by 0.49%. The diff coverage is 80.54%.

@@            Coverage Diff             @@
##           master    #3561      +/-   ##
==========================================
- Coverage   75.43%   74.94%   -0.50%     
==========================================
  Files         247      269      +22     
  Lines       22845    23819     +974     
==========================================
+ Hits        17233    17850     +617     
- Misses       4685     5043     +358     
+ Partials      927      926       -1

Impacted Files	Coverage Δ
action/action_deserializer.go	`57.14% <ø> (ø)`
action/protocol/poll/nativestaking.go	`41.08% <0.00%> (-0.65%)`	:arrow_down:
action/protocol/poll/staking_command.go	`10.71% <0.00%> (ø)`
action/protocol/staking/read_state.go	`15.38% <0.00%> (ø)`
action/protocol/vote/probationlist.go	`87.50% <ø> (ø)`
api/blocklistener.go	`70.73% <0.00%> (ø)`
api/websocket.go	`5.17% <0.00%> (-0.19%)`	:arrow_down:
blockchain/block/block_deserializer.go	`71.15% <ø> (ø)`
blockchain/blockchain.go	`0.89% <0.00%> (ø)`
blockchain/filedao/filedao_legacy.go	`85.80% <ø> (ø)`
... and 119 more