iotex-core icon indicating copy to clipboard operation
iotex-core copied to clipboard

[ioctl] build xrc20 transfer from command line into new ioctl

Open saitofun opened this issue 2 years ago • 8 comments

Description

[ioctl] build xrc20 transfer from command line into new ioctl

Fixes #3339

Type of change

Please delete options that are not relevant.

  • [x] Code refactor or improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x] make test

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

saitofun avatar Jun 11 '22 07:06 saitofun

Codecov Report

Merging #3444 (9cbed1b) into master (a20e489) will decrease coverage by 0.55%. The diff coverage is 79.49%.

@@            Coverage Diff             @@
##           master    #3444      +/-   ##
==========================================
- Coverage   75.43%   74.87%   -0.56%     
==========================================
  Files         247      267      +20     
  Lines       22845    23753     +908     
==========================================
+ Hits        17233    17786     +553     
- Misses       4685     5042     +357     
+ Partials      927      925       -2     
Impacted Files Coverage Δ
action/action_deserializer.go 57.14% <ø> (ø)
action/protocol/poll/nativestaking.go 41.08% <0.00%> (-0.65%) :arrow_down:
action/protocol/poll/staking_command.go 10.71% <0.00%> (ø)
action/protocol/staking/read_state.go 15.38% <0.00%> (ø)
action/protocol/vote/probationlist.go 87.50% <ø> (ø)
api/blocklistener.go 70.73% <0.00%> (ø)
api/websocket.go 5.17% <0.00%> (-0.19%) :arrow_down:
blockchain/block/block_deserializer.go 71.15% <ø> (ø)
blockchain/blockchain.go 0.89% <0.00%> (ø)
blockchain/filedao/filedao_legacy.go 85.80% <ø> (ø)
... and 116 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jun 11 '22 08:06 codecov[bot]

Pls create _test.go and add unit test.

huof6829 avatar Jun 13 '22 06:06 huof6829

@saitofun fix ci Fail

huof6829 avatar Jun 17 '22 15:06 huof6829

@saitofun I fixed, pls check it. Thx

huof6829 avatar Jun 24 '22 12:06 huof6829

@saitofun action_test.go is handling by https://github.com/iotexproject/iotex-core/pull/3472. you can refer to it.

huof6829 avatar Jun 28 '22 05:06 huof6829

xrc20transferfrom_test.go:98 run failed

huof6829 avatar Jul 08 '22 02:07 huof6829

xrc20transferfrom_test.go:98 run failed

already fix it

saitofun avatar Jul 08 '22 03:07 saitofun

after https://github.com/iotexproject/iotex-core/pull/3472 merged, this pr continue. because the same file action.go

huof6829 avatar Jul 14 '22 13:07 huof6829

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 09 '22 17:09 sonarqubecloud[bot]

@huof6829 could you help fix the ci failure?

Liuhaai avatar Sep 09 '22 22:09 Liuhaai