iotex-core icon indicating copy to clipboard operation
iotex-core copied to clipboard

[action] improve coreService.reverseActionsBlock

Open saitofun opened this issue 2 years ago • 4 comments

Description

  • perf: [coreservice] check reverse count
  • test: [coreservice] add proof test

Fixes #3064

Type of change

Please delete options that are not relevant.

  • [x] Code refactor or improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x] make test

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

saitofun avatar May 30 '22 07:05 saitofun

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 30 '22 07:05 CLAassistant

Codecov Report

Merging #3422 (567253b) into master (263ff82) will increase coverage by 0.66%. The diff coverage is 81.27%.

@@            Coverage Diff             @@
##           master    #3422      +/-   ##
==========================================
+ Coverage   74.47%   75.13%   +0.66%     
==========================================
  Files         269      299      +30     
  Lines       23925    25204    +1279     
==========================================
+ Hits        17818    18938    +1120     
- Misses       5174     5294     +120     
- Partials      933      972      +39     
Impacted Files Coverage Δ
action/actctx.go 90.62% <ø> (+6.25%) :arrow_up:
action/action.go 82.35% <ø> (ø)
action/action_deserializer.go 57.14% <ø> (ø)
action/candidate_update.go 88.88% <0.00%> (-4.14%) :arrow_down:
action/consignment_transfer.go 90.41% <ø> (ø)
action/const.go 100.00% <ø> (ø)
action/execution.go 83.78% <ø> (ø)
action/grantreward.go 68.57% <ø> (ø)
action/protocol/account/protocol.go 86.90% <ø> (ø)
action/protocol/dock.go 100.00% <ø> (ø)
... and 276 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar May 30 '22 07:05 codecov[bot]

L 946 has the similar issue

Liuhaai avatar Jun 02 '22 07:06 Liuhaai

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 07 '22 00:09 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jan 19 '23 06:01 sonarqubecloud[bot]