iotex-core
iotex-core copied to clipboard
[actpool] Opt actpool.Add()
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
- [ ] Test A
- [ ] Test B
Test Configuration:
- Firmware version:
- Hardware:
- Toolchain:
- SDK:
Checklist:
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream modules
Codecov Report
Merging #3343 (319b701) into master (a20e489) will decrease coverage by
1.29%
. The diff coverage is79.51%
.
:exclamation: Current head 319b701 differs from pull request most recent head 8f0eb79. Consider uploading reports for the commit 8f0eb79 to get more accurate results
@@ Coverage Diff @@
## master #3343 +/- ##
==========================================
- Coverage 75.43% 74.13% -1.30%
==========================================
Files 247 254 +7
Lines 22845 23479 +634
==========================================
+ Hits 17233 17407 +174
- Misses 4685 5142 +457
- Partials 927 930 +3
Impacted Files | Coverage Δ | |
---|---|---|
actpool/options.go | 100.00% <ø> (ø) |
|
blockchain/blockchain.go | 0.89% <0.00%> (ø) |
|
config/config.go | 94.06% <ø> (+9.31%) |
:arrow_up: |
actpool/config.go | 60.00% <60.00%> (ø) |
|
blockchain/config.go | 65.78% <65.78%> (ø) |
|
action/protocol/poll/protocol.go | 68.13% <66.66%> (-0.35%) |
:arrow_down: |
actpool/actqueue.go | 89.32% <73.33%> (-1.28%) |
:arrow_down: |
dispatcher/dispatcher.go | 73.54% <76.92%> (+2.11%) |
:arrow_up: |
actpool/queueworker.go | 83.54% <83.54%> (ø) |
|
actpool/actpool.go | 87.60% <88.42%> (+0.51%) |
:arrow_up: |
... and 38 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7b8478e...8f0eb79. Read the comment docs.
@CoderZhi pls take another look
@CoderZhi can u PTAL?
This pr has been integrated into pr #3377