iri icon indicating copy to clipboard operation
iri copied to clipboard

White flag

Open acha-bill opened this issue 4 years ago • 0 comments

Description

Ability to confirm conflicting bundle while applying only the first to the ledger. The order of bundles is determined by a topological sort via DFS preferring trunk first.

Fixes #1684

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

  • Existing unit and regression tests pass
  • Added new regression test where a milestone approves 2 double-spend bundles and asserts that even though only 1 affects the ledger, they are both confirmed.

Checklist:

  • [x] My code follows the style guidelines for this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes

acha-bill avatar Mar 20 '20 16:03 acha-bill