identity.rs icon indicating copy to clipboard operation
identity.rs copied to clipboard

WIP: Unify account and advanced examples

Open eike-hass opened this issue 2 years ago • 1 comments

Description of change

TODO: change workflow path in build-and-test.yml:161 and build-and-test.yml:208 back to @dev

TODO: no custom storage example in rust?

Links to any relevant issues

Be sure to reference any related issues by adding fixes issue #.

Type of change

Add an x to the boxes that are relevant to your changes.

  • [ ] Bug fix (a non-breaking change which fixes an issue)
  • [ ] Enhancement (a non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes. Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • [ ] I have followed the contribution guidelines for this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes

eike-hass avatar Apr 21 '22 12:04 eike-hass

I changed the structure of the Rust examples, I deleted some outdated examples. One old example that doesn't have a replacement yet is Resolution it might be important to bring it back/write a new one.

I also didn't check the links in the wiki, these need to be replaced too.

abdulmth avatar Apr 26 '22 21:04 abdulmth

This can be closed, we are following the new examples layout after the Stardust refactor and this contains conflicting changes.

cycraig avatar Sep 20 '22 09:09 cycraig

This can be closed, we are following the new examples layout after the Stardust refactor and this contains conflicting changes.

Indeed, this PR is not relevant any more. The example structure is already updated and this was concerned with the old example build.

eike-hass avatar Sep 20 '22 09:09 eike-hass