firefly icon indicating copy to clipboard operation
firefly copied to clipboard

[Task]: Investigate why some transactions show as burned for restored account

Open brancoder opened this issue 1 year ago • 0 comments

Task description

Sometimes Activities show as Burned on restored account because transaction, that was created on original account, gets returned as part of the results set of the account.incomingTransactions() SDK call while on the original account it gets returned in the account.transactions(). So the consequence is that transaction is "missing" on the restored account. Since transaction is "missing" FF than tries to create Activity, for restored account, from processing outputs associated to the account. The issue is that the account.output() doesn't return all outputs for the "missing" transaction but rather only the "remainder" output. As a result the Activity gets recreated form partial set of outputs and is shown as Burned.

related to https://github.com/iotaledger/firefly/pull/7584#pullrequestreview-1681787736 related to https://github.com/iotaledger/iota-sdk/issues/1502

Requirements

Correctly create Activity for restored account

Creation checklist

  • [ ] I have assigned this task to the correct people
  • [ ] I have added the most appropriate labels
  • [X] I have linked the correct milestone and/or project

brancoder avatar Oct 18 '23 07:10 brancoder