ISHPullUp icon indicating copy to clipboard operation
ISHPullUp copied to clipboard

Embed ISHPullUpViewController in container

Open iSalah opened this issue 7 years ago • 4 comments

Hi,

I've downloaded the sample project and tried to integrate the ISHPullUpViewController in a container view with an embed segue.

When I rotate the device, the layout doesn't follow container bounds. How can I fix this ?

Screenshots below:

Storyboard: Storyboard

Portrait: Portrait

Landscape: Landscape

Thank you,

iSalah avatar Sep 11 '17 11:09 iSalah

It appears that the containing view itself also does not resize properly as the bottom copyright label is not visible. Can you verify that the containing view resizes properly without the PullUp child VC. Also: you may want to set clipsToBounds to yes on the containing view as the pullup extends beyond its bounds.

felixLam avatar Sep 11 '17 13:09 felixLam

Without the PullUp viewcontroller, the main view resizes properly.

I really think there is an issue with orientation change. When I rotate the device from portrait to landscape, it rotates but breaks the layout. Then when I rotate back to portrait, nothing happens.

iSalah avatar Sep 12 '17 09:09 iSalah

Hi @iSalah can you provide a minimal example project to help us reproduce this issue more quickly?

felixLam avatar Sep 20 '17 15:09 felixLam

Hi @felixLam Here is a minimal project based on the sample project. ISHPullUpSample.zip

You can try to rotate the device, then you can't rotate back (nothing happens). Hope that helps.

Thank you

iSalah avatar Sep 21 '17 08:09 iSalah