Ionuț Mihalcea
Ionuț Mihalcea
Changing the packing for a struct is just a matter of adding an attribute to it at build time, right? Could we add a feature to control that, so that...
Hmm, there are now two PRs which attempt to fix the same issue - how come? Do you have a preference for which approach to take? I'll need to go...
Hey! Thanks for raising this - yes, it's a hole in the API that we've not (yet) addressed. We are, however, happy to take PRs for it, so feel free...
Hey! Thanks for the request - any chance you'd be up to contribute those?
Ok, I've had a bit of time to look at this now. > I'm not sure how to fix this. I'm not sure why initialized is in Pkcs11 and not...
> `Arc` will still leave race conditions when two threads try to initialize at the same time. How so? Before you call the backend operation you can [`swap`](https://doc.rust-lang.org/std/sync/atomic/struct.AtomicBool.html#method.swap) the flag...
Ahh, I see. Agree, it's not ideal, though not exactly a showstopper. Would you be ok with the `RwLock` implementation, then? I'll be reviewing that towards getting it in.
Hey! Thanks for the heads-up, the `r2d2` crate does look pretty nice. I'm considering adding some links, perhaps on the README, to crates that have useful "3rd party" functionality. 🤔...