Ionuț Mihalcea

Results 68 comments of Ionuț Mihalcea

Hey - is that one of our unit tests? If not, could you post a link to/copy of the test?

There are still methods to be documented, but I feel like examples are not always needed. I'm curious if we could just make sure there's one test doing each operation...

> Would be nice to see how to implement nv operations as the old library [did](https://gitlab.com/starlab-io/tss-sapi/-/blob/master/examples) Yeah, I kinda like that approach, we're not limited by the same things as...

> @ionut-arm Anyway, separate to me fixing session handling, I think a pre-lim review of this would be great then I'll get it sorted for merge by squashing and fixing...

> Updated based on your comments :) Will have another look when I get a bit of time 👀

I'm good to go, but your commit set seems a bit weird, I wonder if some rebasing happened. Looks like your PR is re-adding two commits from #530

I'd like to help and might try to tackle this in the future if no one's done it by then, but I have limited bandwidth for now. I'd be more...

Luckily this seems to not involve any new structures that need native implementations, which is usually 80% of the work for new commands..

I've tried it locally - just pulling the current tip of `master` of this repo and running the `all-ubuntu.sh` with various versions installed, 2.3.2, 2.3.3, 2.4.0 all seem to pass...

Ok, we can keep this open for now with no pending action just yet