ionos-cloud
Template selection by a subset of tags
*Issue #583
Description of changes: Make VM templates selectable by a subset of tags. Also made the tag search case-insensitive and de-duped both the wanted and present tag lists.
Testing performed: Updated tests.
Tests
Please note that running unit and e2e tests requires manual approval from a team member.
e2e tests
We use labels to control which e2e tests contexts are run:
| Label | Behaviour |
|---|---|
| none | Run Generic tests only |
| https://github.com/ionos-cloud/cluster-api-provider-proxmox/labels/e2e%2Fnone | Do not run any e2e tests |
| https://github.com/ionos-cloud/cluster-api-provider-proxmox/labels/e2e%2Fflatcar | Add Flatcar tests |
ℹ️ Ask a team member to add the requested labels if you don't have enough permissions.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for your contribution. We should be careful with breaking API changes.
Please have a look at our friends over at CAPIC. They've hidden this behind the flag ResolutionPolicy, which defaults to Exact (which is our current behaviour). You could then, for example, put this feature under ResolutionPolicy: Subset.
Agreed @pborn-ionos. Done. I took the opp to bring tag template selection to the cluster classes.