cluster-api-provider-proxmox icon indicating copy to clipboard operation
cluster-api-provider-proxmox copied to clipboard

bump go to 1.22

Open wikkyk opened this issue 1 year ago • 11 comments
trafficstars

Issue #, if available: fix #187

+mass dep update: k8s/api* to 0.30 controller-gen to 0.15.0 (0.14.0 has the go 1.22 panic fix) controller-runtime to 0.18.0 (dependency)

Regenerated crds using new controller-gen. Note config/rbac/role.yaml and config/webhook/manifest.yaml.

wikkyk avatar Apr 25 '24 08:04 wikkyk

obsoletes #190

wikkyk avatar Apr 25 '24 08:04 wikkyk

#177

wikkyk avatar Apr 25 '24 09:04 wikkyk

I will squash this PR into a single commit because none of commits in the PR work without all the other commits in the PR.

wikkyk avatar Apr 25 '24 10:04 wikkyk

@mcbenjemaa you need to be more specific - in what way are they not working?

wikkyk avatar Apr 30 '24 12:04 wikkyk

sorry, my caches

mcbenjemaa avatar Apr 30 '24 12:04 mcbenjemaa

We've decided against merging this until a cluster-api release with controller-runtime v0.18.0 support comes out.

wikkyk avatar Apr 30 '24 16:04 wikkyk

None of the providers moved to 1.22 cause they follow capi:

  • https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/go.mod
  • https://github.com/kubernetes-sigs/cluster-api-provider-gcp/blob/main/go.mod
  • https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/main/go.mod
  • https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/go.mod
  • https://github.com/kubernetes-sigs/cluster-api-provider-packet/blob/main/go.mod
  • https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/main/go.mod

I recommend that we wait for the v1.8 release. To be compliant with CAPI.

mcbenjemaa avatar May 27 '24 08:05 mcbenjemaa

capi 1.7.2 still does not support controller-runtime 0.18

wikkyk avatar Jun 07 '24 11:06 wikkyk

Rebased for v0.5.0.

wikkyk avatar Jun 07 '24 11:06 wikkyk

We can rework this now.

mcbenjemaa avatar Aug 05 '24 08:08 mcbenjemaa

Ready for review.

wikkyk avatar Aug 20 '24 08:08 wikkyk

e2e passed, pushing cosmetic changes to go.mod

wikkyk avatar Aug 20 '24 09:08 wikkyk