cluster-api-provider-proxmox icon indicating copy to clipboard operation
cluster-api-provider-proxmox copied to clipboard

Unify DefaultNetworkDevice and AdditionalNetworkDevices

Open 65278 opened this issue 1 year ago • 3 comments
trafficstars

Describe the solution you'd like At the moment, Network devices are arbitrarily split in two categories, default and additional. This duplicates code and serves no purpose. If we just have an array of NetworkDevices, and require there to be at least 1, we get the same guarantees.

Anything else you would like to add:

  • IP addresses for the first network device are a problem, because they're coming from the cluster object. This needs some architecture.
  • This changes public API. We'll need to go v1alpha2 and provide migration patches.

65278 avatar Apr 24 '24 10:04 65278

We need to be aware of network devices names, for instance, the first device must have the name net0

mcbenjemaa avatar Apr 30 '24 08:04 mcbenjemaa

We could stop creating a default gw for every interface at the same time.

wikkyk avatar May 03 '24 09:05 wikkyk

ref #51

wikkyk avatar May 03 '24 09:05 wikkyk