ion-sfu icon indicating copy to clipboard operation
ion-sfu copied to clipboard

name of media engines are uppercase in pion/webrtc but are lowercase in pion/ion-sfu

Open yindaheng98 opened this issue 2 years ago • 0 comments

Your environment.

  • Version: 68545cc25230220435ee028d5a0af6e768a0a79a
  • Client: github.com/pion/webrtc
  • Environement: Docker
  • Are you using a TURN server? no
  • Other Information - stacktraces, webrtc dumps, related issues, suggestions how to fix, links for us to have context

What did you do?

Try to connect to SFU with a webrtc.Peerconnection, like example code here

What did you expect?

It should connect

What happened?

Unsupported media engine

Cause

I found that the name of media engines in pion/ion-sfu is lowercase: code here

In pion/webrtc however, name of media engines is uppercase: code here

So when I use the code like the example in pion/webrtc, it doesn't work

Also I found the test code in pion/ion-sfu is not the same as the example in pion/webrtc: test code here and example code here

It is not a serious bug but takes me several hours. So why not use the same case?

yindaheng98 avatar Jun 03 '22 08:06 yindaheng98