ionide-vscode-fsharp icon indicating copy to clipboard operation
ionide-vscode-fsharp copied to clipboard

Published 20 hours ago • verified publisher icon ionide

Error checking stops working when ApplicationIcon property inside fsproj is set.

Open marcpiechura opened this issue 2 years ago • 7 comments

Describe the bug

When adding the <ApplicationIcon>Logo.ico</ApplicationIcon> property to the <PropertyGroup> inside the fsproj, error checking stops working and works again once the property gets removed again.

Steps to reproduce

  • Create simple console application via dotnet new
  • Add <ApplicationIcon>Logo.ico</ApplicationIcon> to the fsproj

Expected behaviour

Error checking should work even if the ApplicationIcon is defined

Screenshots

https://user-images.githubusercontent.com/6583600/129420240-0e7de0a1-406a-409f-910a-e087f4dd10ae.mp4

Machine info

  • OS: Windows
  • .NET SDK version: 5.0.302
  • Ionide version: 5.7.1

marcpiechura avatar Aug 13 '21 21:08 marcpiechura

Hey @marcpiechura :wave:,

Thank you for opening an issue. We will get back to you as soon as we can. Also, check out our OpenCollective and consider backing us.

https://opencollective.com/ionide

PS.: We offer backer support for all backers. Don't forget to add backer label when you start backing us :smile:

open-collective-bot[bot] avatar Aug 13 '21 21:08 open-collective-bot[bot]

Total shot in the dark, but have you tried the latest SDK SDK 5.0.400?

ApplicationIcon had some problems with the compiler until somewhat recently, but I honestly can't say for sure which SDK release shipped a compiler with the updates to make it recognized.

cartermp avatar Aug 13 '21 21:08 cartermp

@cartermp thanks for the quick response. Tried it right now, but unfortunately with the same outcome.

marcpiechura avatar Aug 13 '21 22:08 marcpiechura

Gah, bummer. Confirmed that this does work in Visual Studio, so at least it's not an upstream problem.

cartermp avatar Aug 13 '21 22:08 cartermp

Try ">developer reload", or close file, close folder, and reopen? This is a different setting, but it looks like the same scenario as described here https://github.com/ionide/ionide-vscode-fsharp/issues/1500. Seem booksbaum's example.

nhirschey avatar Aug 14 '21 15:08 nhirschey

Thanks for the suggestion, but my issue seems to be much more persistent, it either works or it doesn’t work. Before I figured out what was causing the issue, I even tried to restart my PC, unfortunately without any affect, only after this I started to undo my recent changes until it worked again.

marcpiechura avatar Aug 14 '21 16:08 marcpiechura

Just wanted to mention that I've had the same problem where Error checking stoped working. Commented out the <ApplicationIcon> and it started working again.

Tested on two different Windows clients.

yoHasse avatar Nov 08 '21 10:11 yoHasse