ionide-vscode-fsharp icon indicating copy to clipboard operation
ionide-vscode-fsharp copied to clipboard

Suggestion: Improved intellisense on double back tick members.

Open magnushammar opened this issue 5 years ago • 3 comments

This is arguably a very low priority suggestion. When working on Fable bindings for Node.js there is a lot of naming collisions, in this case with end.
In the illustrated case it doesn't really make sense to get a suggestion for the reserved keyword end. It would make more sense if the double back ticked end was listed.

image

magnushammar avatar May 17 '19 10:05 magnushammar

Hey @magnushammar :wave:,

Thanks for backing our project. If possible, We will handle your issue with priority support. To make sure we don't forget how special you are, we added a backer label to your issue.

Thanks again for backing us :tada:!

This code should probably be changed. TBF, no idea why it's like this, @baronfel any ideas?

https://github.com/fsharp/FsAutoComplete/blob/main/src/FsAutoComplete/FsAutoComplete.Lsp.fs#L1062-L1068

Krzysztof-Cieslak avatar Jul 23 '22 22:07 Krzysztof-Cieslak

Best guess is that there may have been some bugs in the 'add backticks if needed' FCS API, or we wanted to do a potential shortcut. We can definitely put this scenario under test and remove the customization if it is no longer required 👍

baronfel avatar Jul 23 '22 22:07 baronfel