Ionide-vim icon indicating copy to clipboard operation
Ionide-vim copied to clipboard

Ionide-vim will no longer install FSAC on its own

Open cannorin opened this issue 2 years ago • 2 comments

Related: https://github.com/fsharp/FsAutoComplete/issues/883 FsAutoComplete now encourage users to manage FSAC via dotnet tool: dotnet tool install fsautocomplete for project-local install and dotnet tool install -g fsautocomplete for global install. Ionide-vim used to manage FSAC on its own, but following the above change, it will no longer do so and will require users to install FSAC via dotnet tool install.

  • The command :FSharpUpdateFSAC will be removed.
  • The default value of g:fsharp#fsautocomplete_command will be ['fsautocomplete', '--background-service-enabled'] (globally-installed FSAC).
  • Ionide-vim will no longer require running make fsautocomplete on installation.

cannorin avatar Feb 06 '22 06:02 cannorin

Instead of getting rid of installation entirely, maybe do dotnet install -g fsautocomplete in the Makefile instead? Might be less surprising for people not paying attention to these issues. Just a suggestion...

One potential problem is that running global tools requires the user has ~/.dotnet/tools in $PATH (or equivalent on windows) properly.

tnishimura avatar Feb 08 '22 00:02 tnishimura

Instead of getting rid of installation entirely, maybe do dotnet install -g fsautocomplete in the Makefile instead? Might be less surprising for people not paying attention to these issues. Just a suggestion...

One potential problem is that running global tools requires the user has ~/.dotnet/tools in $PATH (or equivalent on windows) properly.

Could be done, but I'd still recommend not auto-running the makefile then, imo.

zetashift avatar Feb 12 '22 19:02 zetashift