FsAst icon indicating copy to clipboard operation
FsAst copied to clipboard

Update to FCS 40

Open baronfel opened this issue 4 years ago • 7 comments

We're blocked from doing this until fantomas has a version that supports FCS 40. There's a branch with that work, but no prerelease/stable quite yet.

baronfel avatar Aug 04 '21 14:08 baronfel

Wouldn't be a good idea to keep FCS used here in sync with FCS version in Fantomas? Had problems using different versions

Heck, I even thought about including FsAst into Fantomas (maybe in a .Writers namespace) since they are always used together

Zaid-Ajaj avatar Aug 04 '21 14:08 Zaid-Ajaj

Wouldn't be a good idea to keep FCS used here in sync with FCS version in Fantomas? Had problems using different versions

yes, that's precisely why the associated MR is in draft state still :p

baronfel avatar Aug 04 '21 14:08 baronfel

@nojaf speaking of, any idea when the first prereleases of fantomas with FCS40 will drop? I'm also looking forward to those for FSAC itself

baronfel avatar Aug 04 '21 14:08 baronfel

Hey, yeah about that 🙈. I'm currently pitching the idea of having a patch release for FCS 40. There is one thing that just really doesn't produce AST anymore. And another fix that would allow for a huge clean up in Fantomas. I've poked @vzarytovskii about it and they would discuss it internally.

nojaf avatar Aug 04 '21 15:08 nojaf

the thing is, even that proposed patch release would be a major version bump (due to api breakages). so it sounds like you're suggesting skipping 40 entirely?

baronfel avatar Aug 04 '21 15:08 baronfel

It has crossed my mind, to be honest. The daemon experiment could potentially resolve the hurdle in FSAC. And as for FsAst, I'm not sure what the impact would be. If there is any...

nojaf avatar Aug 04 '21 15:08 nojaf

https://www.nuget.org/packages/FSharp.Compiler.Service/40.0.1-preview.21352.5 just dropped, I'll check over the weekend if I can publish the first alpha.

nojaf avatar Aug 06 '21 07:08 nojaf