bug: e2e tests break between 4.35.0 and 4.35.3 if puppeteer version is below 24

[atomassoni]

Prerequisites

• [x] I have read the Contributing Guidelines.
• [x] I agree to follow the Code of Conduct.
• [x] I have searched for existing issues that already report this problem, without success.

Stencil Version

4.36.0

Current Behavior

Stencil end to end tests were working on version 4.35.0, we upgraded to 4.35.3 and they started erroring. This problem is still present on 4.36.0

The error is verified on macOS ARM and Linux so far.

Expected Behavior

Either the tests work with any current version of puppeteer that is allowed, or there is a warning about using puppeteer below version 24 when running e2e tests. It would be nice if there was a breaking change documented by Stencil and at least a minor version update to alert that something needs to update.

System Info

System: node 20.18.3
    Platform: darwin (23.6.0)
   CPU Model: Apple M3 Pro (12 cpus)
    Compiler: /Users/annetomassoni/dev/stencil-e2e-bug/node_modules/@stencil/core/compiler/stencil.js
       Build: 1752598220
     Stencil: 4.36.0 🎊
  TypeScript: 5.5.4
      Rollup: 4.34.9
      Parse5: 7.2.1
      jQuery: 4.0.0-pre
      Terser: 5.37.0

Steps to Reproduce

Get the code reproduction repo on the desired environment. Then:

1. Install dependencies

   npm install
   

2. Run E2E tests

   npm test
   

   Expected error (tested on macOS ARM):

   [ ERROR ]  Unable to detect browser executable path for 'undefined' on mac_arm.
   Error: Unable to detect browser executable path for 'undefined' on mac_arm.
   at Object.resolveSystemExecutablePath ...
   

3. Upgrade Puppeteer to v24

   npm install puppeteer@24
   

4. Run E2E tests again

   npm test
   

   Expected result:
   Tests should now run.

Code Reproduction URL

https://github.com/atomassoni/stencil-puppeteer-bug-repro

Additional Information

No response