stencil icon indicating copy to clipboard operation
stencil copied to clipboard

bug: "module" property warning on `www` output target

Open George-Payne opened this issue 2 years ago • 1 comments

Prerequisites

Stencil Version

2.17.4

Current Behavior

When building an www output target you get the warning:

[ WARN ] Package Json: package.json package.json "module" property is required when generating a distribution.

Expected Behavior

No warning, a www target doesn't need a module property

Steps to Reproduce

  1. clone reproduction repo
  2. switch to branch www-warning
  3. npm install
  4. npm run dev Observe:
[01:16.3]  @stencil/core
[01:16.6]  v2.17.4 🐞
[01:18.8]  build, example, prod mode, started ...
[01:18.8]  transpile started ...
[01:21.8]  transpile finished in 2.95 s
[01:21.8]  copy started ...
[01:21.8]  generate lazy started ...
[01:21.8]  copy finished (0 files) in 38 ms
[01:22.7]  generate lazy finished in 968 ms

[ WARN  ]  Package Json: package.json
           package.json "module" property is required when generating a distribution.

[01:22.7]  build finished in 3.95 s
  1. Note the warning

Code Reproduction URL

https://github.com/George-Payne/stencil-bug-reproductions/tree/www-warning

Additional Information

Introduced in: #3475

George-Payne avatar Aug 31 '22 15:08 George-Payne

Thanks @George-Payne! I was able to confirm this is a bug and will get it ingested for the team to take a look at!

rwaskiewicz avatar Aug 31 '22 15:08 rwaskiewicz

This should no longer be an issue in Stencil v4 with the introduction of primary package output target validation

tanner-reits avatar Aug 01 '23 19:08 tanner-reits