stencil icon indicating copy to clipboard operation
stencil copied to clipboard

fix(service-workers): don't filter out xxx.esm.js

Open manucorporat opened this issue 4 years ago • 1 comments

Pull request checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • [ ] Build (npm run build) was run locally and any changes were pushed
  • [ ] Unit tests (npm test) were run locally and passed
  • [ ] E2E Tests (npm run test.karma.prod) were run locally and passed
  • [ ] Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

What is the current behavior?

GitHub Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • [ ] Yes
  • [ ] No

Testing

Other information

manucorporat avatar Oct 11 '21 09:10 manucorporat

Hey @manucorporat 👋

Thanks for the PR - would you mind filling out the template above? That helps give myself/the rest of the team some additional context when reviewing PRs from folks - primarily the "why" someone is asking us to make a change. This is super helpful for the team and I while we're coming up on the codebase to help us make the most educated decisions that we can while we fill our knowledge gaps.

It also looks like Prettier is failing CI, which can be fixed by running npm run prettier from the root of the project.

Thanks!

rwaskiewicz avatar Oct 18 '21 12:10 rwaskiewicz

👋 Thanks for all of your work on Stencil over the years! Due to inactivity, we’re going to close this PR out. If anyone is interested in the functionality described here, please feel free to open a new issue in the repo. Thanks!

rwaskiewicz avatar Nov 29 '23 20:11 rwaskiewicz