stencil icon indicating copy to clipboard operation
stencil copied to clipboard

ion-content fullscreen freezes the prerender process

Open HaythemSahbani opened this issue 4 years ago • 5 comments

Stencil version:

 @stencil/[email protected]

I'm submitting a:

[x] bug report [ ] feature request [ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

Current behavior:

Hi I am trying to prerender the ionic-stencil starter app. However when adding fullscreen to the ion-content element the prerender process becomes inresponsive and I have to manually kill the process. Expected behavior:

The prerendering process doesn't freez Steps to reproduce:

  1. Run npm init stencil, (choose the ionic pwa)
  2. in the generated home.tsx file add fullscreen={true} or fullscreen to the ion-content
  3. Build with prerender, npm run build -- --prerender Related code:
// insert any relevant code here

Other information:

HaythemSahbani avatar May 11 '20 13:05 HaythemSahbani

+1 I just ran into this issue myself! - repro steps outlined above

corysmc avatar May 21 '20 18:05 corysmc

Same here. After some debugging I discovered what seems to be an infinite loop that keeps rendering the ion-content indefinitely. Confirmed by logging calls to updateComponent.

tricki avatar Jun 28 '20 17:06 tricki

Same here. Really problematic as a pretty important property in an app design ! Any update ?

cptflammin avatar Sep 08 '21 13:09 cptflammin

Could folks update to the latest versions of Stencil and Framework and help me understand if this still exists? It would be super helpful as well if we could get a GitHub repo with the recreation steps so we can quickly identify and resolve the issue.

splitinfinities avatar Sep 08 '21 13:09 splitinfinities

I just created a new project (npm init stencil), added fullscreen={true} and configured a base URL and can reproduce the bug. Here's the repo (with VS Code prerender launch configured): https://github.com/tricki/stencil-fullscreen-prerender-bug Just run npm run build --prerender to reproduce it.

I still see updateComponent being called in an endless loop for ion-content. Here's the call stack (note updateComponent at the top and bottom):

image

tricki avatar Sep 08 '21 14:09 tricki

Hey folks. A fix for this issue was released as a part of Ionic Framework v7.0.6. As a result, I'm going to close out this issue. If this issue should reappear, please feel free to open a new issue. Thanks!

rwaskiewicz avatar May 15 '23 14:05 rwaskiewicz