stencil-store icon indicating copy to clipboard operation
stencil-store copied to clipboard

Store malfunction

Open olivier65 opened this issue 3 years ago • 11 comments

Stencil version: stencil-bug1.zip

 @stencil/[email protected]
 @stencil/[email protected]

I'm submitting a: [x] bug report [ ] feature request [ ] support request stencil-bug1.zip

Current behavior: The store is not reactive.

Expected behavior: The store should work as described in the docs.

Steps to reproduce: See README.md in the attached zip file, which is a complete project.

olivier65 avatar Aug 02 '21 21:08 olivier65

Author Solved in ionic-team/stencil#2988

splitinfinities avatar Aug 03 '21 21:08 splitinfinities

Please pay attention and reopen this issue!!! What was solved in ionic-team/stencil#2988 is a different issue! I just couldn't be arsed to create separate supporting projects for each.

olivier65 avatar Aug 03 '21 21:08 olivier65

Apologies, @olivier65, I wasn't sure the repro case. Could you add your .zip file as a github repo instead?

splitinfinities avatar Aug 03 '21 21:08 splitinfinities

Sigh. Why this fixation on repos when the repo may disappear at some point and the context of the issue be lost? Seems to me that keeping everything self-contained is much preferable. Also, there is no practical difference between git clone and unzip -x. Anyway, the repo is https://github.com/olivier65/stencil-bug1; just ignore the part about Event.

olivier65 avatar Aug 03 '21 22:08 olivier65

Awesome! Thank you, I appreciate the update and the patience. From what I gather, maybe something about store depends on @State. From what you share, @State is not applied to the consumer, it breaks. When @State is applied, it seems to work. I'm curious if this has something to do with how we minify/treeshake functions out of component definitions.

No timeline on a fix, but I have a better idea of what may be happening. I'll circle back. Thanks again!

Edit: Clarified some stuff

splitinfinities avatar Aug 03 '21 22:08 splitinfinities

Maybe a misunderstanding? @State doesn't break the store: on the contrary adding @State somewhere in this project makes the store work, which is hard to explain.

olivier65 avatar Aug 03 '21 22:08 olivier65

Thanks for the issue! This issue is being closed due to inactivity. If this is still an issue with the latest version of Stencil, please create a new issue and ensure the template is fully filled out.

Thank you for using Stencil!

ionitron-bot[bot] avatar Sep 03 '21 00:09 ionitron-bot[bot]

Hey ionitron-bot, we didn't mean to close this. Bad bot!

rwaskiewicz avatar Sep 03 '21 12:09 rwaskiewicz

👋 As a bit of housekeeping, I'm going to move this issue to the Stencil Store repo

rwaskiewicz avatar Feb 16 '22 13:02 rwaskiewicz

@rwaskiewicz this is not solvable on the Stencil Store side. There is already an issue there for this issue: https://github.com/ionic-team/stencil-store/issues/44

Also, can anyone from Ionic review the PRs there, please?

Serabe avatar Feb 16 '22 20:02 Serabe

This is related to https://github.com/ionic-team/stencil/issues/4135

malarahfelipe avatar Apr 21 '23 18:04 malarahfelipe