stencil-sass icon indicating copy to clipboard operation
stencil-sass copied to clipboard

Published 20 hours ago • verified publisher icon ionic-team

Make `sass` a peerDependency

Open Richienb opened this issue 2 years ago • 2 comments

Fixes #61, fixes #55

Richienb avatar Sep 23 '21 13:09 Richienb

It has been a year since this pull request was created. Having to depend on an old sass version is starting to become a problem. Why is this being blocked?

kyubisation avatar Oct 19 '22 07:10 kyubisation

👋

The team is aware of this painpoint and I can confirm its on our radar. We recently released the first version of this package in almost a year last month in order to get most dependencies updated. That is to say, we haven't forgotten about this library/issue.

Sass itself is central to this library - the current Stencil team (who aren't the original authors of this package) need to do additional analysis/planning around the coupling between Sass, the typings it exports, and this library to see what the chances of a new minor/patch version of Sass breaking this package is in order to make an informed decision as to whether to move forward with this PR or not. In the mean time, we thank you all for your patience!

rwaskiewicz avatar Oct 19 '22 13:10 rwaskiewicz

Thanks! For the reasons outlined in https://github.com/ionic-team/stencil-sass/issues/61#issuecomment-1306171922, we've decided not to accept this PR. While this is often not what contributors wish to hear, I want to say that this PR led to excellent discussion amongst the team and is most appreciated. Thanks again!

rwaskiewicz avatar Nov 07 '22 20:11 rwaskiewicz