starters icon indicating copy to clipboard operation
starters copied to clipboard
verified publisher icon ionic-team

chore(angular-standalone): add preloading strategy

Open luisbytes opened this issue 1 year ago • 3 comments

Hi, I noticed that the starter template with Angular and ngModules has preloading enabled by default, but the standalone one does not

luisbytes avatar Apr 22 '24 16:04 luisbytes

Hi @sean-perkins, I see that the tests passed correctly, let me know if I can help with anything else for the merge.

luisbytes avatar May 08 '24 13:05 luisbytes

@sean-perkins , I see that the tests continue to fail, the strange thing is that I don't modify any of that, how could I help? Creating the pull again from scratch?

luisbytes avatar May 08 '24 15:05 luisbytes

@luisbytes to be honest I'm not certain why they are failing consistently here. I didn't run into with a PR after yours was created: https://github.com/ionic-team/starters/pull/1843 and was able to re-run the action for a PR from Liam.

I was able to reproduce the behavior locally, but only intermittently, so the test itself is likely flaky. It's only a challenge in the unit test, so I'm inclined to just skip it for now and come back to it.

sean-perkins avatar May 08 '24 19:05 sean-perkins