starters icon indicating copy to clipboard operation
starters copied to clipboard

fix: rename .eslintrc.js to .eslintrc.cjs in esm projects

Open mattschlosser opened this issue 1 year ago • 0 comments

Closes ionic-team/ionic-cli#5015

Currently, Running npm run lint in the vue-vite and react-vite starter projects is broken.

ESLint fails to properly parse the .eslintrc.js file in these two starter projects because it relies on the nearest package.json file to infer whether to interpret .js files as ES Modules or a CommonJS ones. The nearest package.json states: "type": "module". As such, node attempts to parse the .eslintrc.js file as an ES Module, and fails. The error message suggests either converting the file to an ES Module, or renaming the file to .eslintrc.cjs to explicitly declare it is a CommonJS file. I've chosen to do the latter.

This PR fixes the issue in both starter projects.

npm run lint works now! 🎉

mattschlosser avatar Jun 15 '23 04:06 mattschlosser