ionic-framework icon indicating copy to clipboard operation
ionic-framework copied to clipboard

feat(checkbox): display as block when justify or alignment properties are defined

Open brandyscarney opened this issue 1 year ago • 1 comments

Issue number: internal


What is the current behavior?

When adding the justify or alignment property to an ion-checkbox it does not change the design because the checkbox is displayed inline.

What is the new behavior?

  • Change the checkbox's display property to block when the justify or alignment property is set.
  • Set the default justify-content style to space-between so that a checkbox with width: 100% set without justify or alignment set will still have the same default
  • Modifies the label e2e test to remove the explicit width as setting the property will make them full-width
  • Adds two examples to the label e2e test of labels that do not have justify set but use width: 100% to ensure they are working as expected without it

Does this introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

brandyscarney avatar Aug 20 '24 14:08 brandyscarney

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 8:05pm

vercel[bot] avatar Aug 20 '24 14:08 vercel[bot]