ionic-framework
ionic-framework copied to clipboard
fix(range): disable scroll when range is being dragged
Issue number: internal
What is the current behavior?
There are a few tests that were disabled due to being flaky from gestures.
What is the new behavior?
While fixing the tests, I found a bug that the scroll was never being disabled on scroll. Additionally, we were not taking into account that a custom scroll target could be used so it was never disabled either.
- Fixed the flaky tests.
- Content doesn't scroll when range is being dragged.
- Content can be either
ion-contentor a custom scroll target.
Does this introduce a breaking change?
- [ ] Yes
- [x] No
Other information
Preview for ion-content
Preview for custom scroll target
How to test:
- Open either of the previews
- Render the screen with the device simulator from the browser
- Verify that you can scroll the page
- Drag the range but don't let go
- Verify that you cannot scroll the page
- Repeat steps 2-5 with the other preview
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| ionic-framework | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 18, 2024 9:25pm |