ionic-framework
ionic-framework copied to clipboard
chore(visual-regression): add script to update ground truths
Issue number: N/A
What is the current behavior?
Devs would have to manually generate the ground truths from their desired base branch. This causes a dev to checkout the base branch and pull the latest screenshots. They would then return to their working branch and start the E2E tests.
What is the new behavior?
A script has been created to automate this process using Docker as mentioned in the design doc:
- It will ask the user a set a questions like if which component they want to test
Does this introduce a breaking change?
- [ ] Yes
- [x] No
Other information
How to test:
- Make a change to a desired component
- Run
npm run test.e2e.script - Answer the questions
- Verify that the tests fail due to visual changes
- Re-run the command as many times as necessary in order to try different routes based on different answers
Also adding Liam and Brandy as reviewers since they've worked on the visual regression changes.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| ionic-framework | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 9, 2024 9:38pm |
@brandyscarney ready for review