ionic-framework icon indicating copy to clipboard operation
ionic-framework copied to clipboard

chore(visual-regression): add script to update ground truths

Open thetaPC opened this issue 1 year ago • 3 comments

Issue number: N/A


What is the current behavior?

Devs would have to manually generate the ground truths from their desired base branch. This causes a dev to checkout the base branch and pull the latest screenshots. They would then return to their working branch and start the E2E tests.

What is the new behavior?

A script has been created to automate this process using Docker as mentioned in the design doc:

  • It will ask the user a set a questions like if which component they want to test

Does this introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

How to test:

  1. Make a change to a desired component
  2. Run npm run test.e2e.script
  3. Answer the questions
  4. Verify that the tests fail due to visual changes
  5. Re-run the command as many times as necessary in order to try different routes based on different answers

thetaPC avatar Mar 22 '24 23:03 thetaPC

Also adding Liam and Brandy as reviewers since they've worked on the visual regression changes.

thetaPC avatar Apr 01 '24 18:04 thetaPC

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 9:38pm

vercel[bot] avatar Apr 16 '24 17:04 vercel[bot]

@brandyscarney ready for review

thetaPC avatar May 02 '24 18:05 thetaPC