ionic-framework icon indicating copy to clipboard operation
ionic-framework copied to clipboard

bug: IonTabButton doesn't have default HTML event attributes typed

Open aeharding opened this issue 1 year ago • 1 comments

Prerequisites

Ionic Framework Version

v7.x

Current Behavior

IonTabButton is missing regular HTML types (onPointerDown, onTouchEnd, onTouchMove, etc)

Expected Behavior

Should have proper types.

Steps to Reproduce

Try to add onPointerDown to IonTabButton in React. Typescript will complain, but the touch end handler will be properly connected/called.

Code Reproduction URL

https://stackblitz.com/edit/wl7fhb-xaawyq?file=src%2Fmain.tsx

Ionic Info

N/A - stackblitz

Additional Information

No response

aeharding avatar Mar 18 '24 17:03 aeharding

Thank you for submitting the issue!

I was able to replicate it. I verified that onClick doesn't cause any type errors. I would recommend using that as a workaround.

thetaPC avatar Mar 21 '24 21:03 thetaPC

Thanks for the issue! This has been resolved via PR https://github.com/ionic-team/ionic-framework/pull/29736 and will be available in an upcoming release of Ionic.

thetaPC avatar Aug 02 '24 22:08 thetaPC

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

ionitron-bot[bot] avatar Sep 01 '24 23:09 ionitron-bot[bot]