ionic-framework icon indicating copy to clipboard operation
ionic-framework copied to clipboard

bug: large title transition does not account for empty back button text

Open roman-rr opened this issue 1 year ago • 2 comments

Prerequisites

Ionic Framework Version

v7.x, Nightly

Current Behavior

Only with @Ionic/angular > 7.5.0, when ion-back-button has empty text value:

Screenshot 2023-12-21 at 15 28 40

Note that text=" " doesn't give a error.

Expected Behavior

Allow text="" for ion-back-button component

Steps to Reproduce

  1. git clone https://github.com/roman-rr/bug-backbutton.git
  2. cd bug-backbutton
  3. npm i
  4. ionic serve
  5. Click button

Code Reproduction URL

https://github.com/roman-rr/bug-backbutton/

Ionic Info

Ionic:

Ionic CLI : 7.1.5 (/usr/local/lib/node_modules/@ionic/cli) Ionic Framework : @ionic/angular 7.6.2 @angular-devkit/build-angular : 17.0.7 @angular-devkit/schematics : 17.0.7 @angular/cli : 17.0.7 @ionic/angular-toolkit : 9.0.0

Capacitor:

Capacitor CLI : 5.6.0 @capacitor/android : not installed @capacitor/core : 5.6.0 @capacitor/ios : not installed

Utility:

cordova-res (update available: 0.15.4) : 0.14.0 native-run : 2.0.0

System:

NodeJS : v20.10.0 (/usr/local/bin/node) npm : 10.2.3 OS : macOS Unknown

Additional Information

No response

roman-rr avatar Dec 21 '23 08:12 roman-rr

Faced the same issue. A white space as "text" solve temporary the issue

<ion-back-button text=" " [defaultHref]="defaultHref"></ion-back-button>

alexdabast avatar Dec 21 '23 15:12 alexdabast

For me this only occurs in iOS mode. Using the temporary solution of @alexdabast for now.

Visually the app will navigate to the desired page, but without any animations. On MD-mode the animations still occur.

Mdemol avatar Jan 24 '24 13:01 Mdemol

Hi everyone,

Here is a dev build with a proposed fix if anyone is interested in testing: 7.8.5-dev.11713282122.18cabf98

liamdebeasi avatar Apr 11 '24 16:04 liamdebeasi

Thanks for the issue. This has been resolved via https://github.com/ionic-team/ionic-framework/pull/29327, and a fix will be available in an upcoming release of Ionic Framework.

liamdebeasi avatar Apr 30 '24 15:04 liamdebeasi

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

ionitron-bot[bot] avatar May 30 '24 16:05 ionitron-bot[bot]