ionic-framework icon indicating copy to clipboard operation
ionic-framework copied to clipboard

bug: Ionic refresher gesture double mounted with incorrect ion-content-scroll-host

Open aeharding opened this issue 2 years ago • 1 comments

Prerequisites

Ionic Framework Version

v7.x

Current Behavior

In certain cases, a non-native IonRefresher gesture handler will get double-mounted (you can tell by stepping through code and seeing this.gesture in refresher.ts is called twice in a row).

One of the mounts will have the incorrect .ion-content-scroll-host setup and it causes the feed to refresh any time you try to scroll up.

Note: I realize the IonRefresher is being (ab)used, mounted then quickly unmounted and remounted, and there's a better way to do this where it will not cause a double-mounted gesture. However, I'm experiencing this issue in Voyager intermittently (see: https://github.com/aeharding/voyager/issues/718). This reproduction is just the best way I can demonstrate this issue in a consistently reproducible manner.

Expected Behavior

Gestures should never be double mounted. .ion-content-scroll-host should always be correctly connected.

Steps to Reproduce

  1. Clone reproduction
  2. pnpm i
  3. ionic serve
  4. Using an Android device, or Chrome simulator emulating an Android device, scroll down, then scroll up. See feed refresh.

Code Reproduction URL

https://github.com/aeharding/refresher-race

Ionic Info

Ionic:

   Ionic CLI       : 7.1.1 (/Users/aeharding/.nvm/versions/node/v20.8.1/lib/node_modules/@ionic/cli)
   Ionic Framework : @ionic/react 7.5.1

Capacitor:

   Capacitor CLI      : 5.5.1
   @capacitor/android : not installed
   @capacitor/core    : 5.5.1
   @capacitor/ios     : not installed

Utility:

   cordova-res : not installed globally
   native-run  : not installed globally

System:

   NodeJS : v20.8.1 (/Users/aeharding/.nvm/versions/node/v20.8.1/bin/node)
   npm    : 10.1.0
   OS     : macOS Unknown

Additional Information

https://github.com/aeharding/voyager/issues/718

https://github.com/ionic-team/ionic-framework/assets/2166114/069c842d-135b-4d18-8161-5b088db6df50

aeharding avatar Nov 06 '23 00:11 aeharding

Hey there,

I can reproduce the reported behavior, but I'm not able to reproduce the issue outside of your application so I'm going to look into this a bit more. (Anyone else on the team: Feel free to take a look/post your findings)

liamdebeasi avatar Nov 08 '23 15:11 liamdebeasi