ionic-framework
ionic-framework copied to clipboard
fix(datetime): swiping wheel no longer dismisses card modal
Pull request checklist
Please check if your PR fulfills the following requirements:
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
- Some docs updates need to be made in the
ionic-docsrepo, in a separate PR. See the contributing guide for details.
- Some docs updates need to be made in the
- [x] Build (
npm run build) was run locally and any changes were pushed - [x] Lint (
npm run lint) has passed locally and any fixes were made for failures
Pull request type
Please check the type of change your PR introduces:
- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):
What is the current behavior?
Issue URL: N/A
https://stackblitz.com/edit/angular-ahhenz?file=src%2Fapp%2Fexample.component.html,src%2Fapp%2Fapp.component.html
Brandy mentioned that it is possible to swipe to close the card modal when scrolling the wheel picker.
| before | after |
|---|---|
What is the new behavior?
- When scrolling on the wheel picker, the
touchstartevent will not bubble. This is because the scrolling should take priority over other gestures.
Native iOS example: Observe that the card modal's gesture does not activate when swiping on the wheels.
Does this introduce a breaking change?
- [ ] Yes
- [x] No