ionic-framework icon indicating copy to clipboard operation
ionic-framework copied to clipboard

fix(react): overlays now define internal ionic components

Open liamdebeasi opened this issue 3 years ago • 0 comments

Pull request checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • [x] Build (npm run build) was run locally and any changes were pushed
  • [x] Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

What is the current behavior?

Issue URL: resolves https://github.com/ionic-team/ionic-framework/issues/25962

Alert, Loading, Picker, and Toast in React did not use the defineCustomElements function provided by stencil. As a result, any child Ionic components were not being defined. This impacted IonLoading which uses IonSpinner internally.

What is the new behavior?

  • Alert, Loading, Picker, and Toast definitions in React now use defineCustomElements.

Does this introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

liamdebeasi avatar Sep 19 '22 14:09 liamdebeasi