ionic-framework icon indicating copy to clipboard operation
ionic-framework copied to clipboard

feat(textarea): ionChange will only emit from user committed changes

Open sean-perkins opened this issue 3 years ago • 0 comments

Pull request checklist

Please check if your PR fulfills the following requirements:

  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • [x] Build (npm run build) was run locally and any changes were pushed
  • [x] Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

What is the current behavior?

Textarea emits ionChange each time the value is modified internally (e.g. user typing) or externally (e.g. value being set programmatically).

Issue URL: Internal

What is the new behavior?

  • ionChange is only emitted when the inner textarea change event is fired.
  • debounce applies to the ionInput event instead of ionChange

Does this introduce a breaking change?

  • [x] Yes
  • [ ] No

Other information

sean-perkins avatar Sep 16 '22 16:09 sean-perkins