cordova-plugin-wkwebview-engine icon indicating copy to clipboard operation
cordova-plugin-wkwebview-engine copied to clipboard

Lack of tagged releases for more recent versions

Open mjosephd opened this issue 8 years ago • 0 comments

There seems to be a lack of tags for the more recent releases. This is a problem because we cannot specify the verision we want to use in the config.xml

For example the following config.xml plugin import will get the latest version

So if we want to use a set version we need to use the following format

The only problem is that there does not seem to be tags for the recent versions even though the package version history says otherwise. This can cause a problem because if a version like "1.1.2-dev" is used it cant be explicitly set and 1.1.2-dev can be upgraded any time.

Here is a change in the package.json to reflect a version upgrade

https://github.com/driftyco/cordova-plugin-wkwebview-engine/commit/1c8ef9ab635e490e727f1d6c77a10b5e2b6db5c2#diff-b9cfc7f2cdf78a7f4b91a753d10865a2

However this version cannot be found in the tags

This is the error for an incorrect version (version without a tag).

Fetching plugin "https://github.com/driftyco/cordova-plugin-wkwebview-engine.git" via git clone
Failed to restore plugin "cordova-plugin-wkwebview-engine" from config.xml. You might need to try adding it again. Error: Failed to fetch plugin https://github.com/driftyco/cordova-plugin-wkwebview-engine.git via git.
Either there is a connection problems, or plugin spec is incorrect:
	Error: git: Command failed with exit code 1 Error output:
error: pathspec '1.1.2-dev' did not match any file(s) known to git.

And this is with a tagged version

Discovered plugin "cordova-plugin-wkwebview-engine" in config.xml. Adding it to the project
Fetching plugin "https://github.com/driftyco/cordova-plugin-wkwebview-engine.git" via git clone
Repository "https://github.com/driftyco/cordova-plugin-wkwebview-engine.git" checked out to git ref "1.0.2".
Installing "cordova-plugin-wkwebview-engine" for ios

mjosephd avatar Apr 24 '17 15:04 mjosephd