capacitor icon indicating copy to clipboard operation
capacitor copied to clipboard

fix(android): respect all allowed origins on modern WebViewCompat JS injection

Open martin-braun opened this issue 1 year ago • 6 comments
trafficstars

Fixes #7454

I applied the fix from @rfe-css at https://github.com/ionic-team/capacitor/issues/7454, but I figured my device would skip this, so please someone can verify this before merge.

martin-braun avatar Jul 19 '24 13:07 martin-braun

Is there a chance this to be merged?

michaelkhabarov avatar Sep 21 '24 20:09 michaelkhabarov

Since I added this fix, I had the chance to test it on a device that was affected by the bug and this patch works flawlessly.

@michaelkhabarov No idea at this point. I got silenced at #7570, too, but it's an entirely different issue that was confused with the existing one.

It makes me feel discouraged for contributing any further.

martin-braun avatar Sep 21 '24 21:09 martin-braun

Soooo, can we merge this or what?

marcusdiy avatar Feb 03 '25 17:02 marcusdiy

Soooo, can we merge this or what?

It was free of conflicts and ready to merge for months after I created the PR, but the maintainers did not look into this. Now, we have a new major Capacitor version. So the issue is still present? I'm just using my patched fork to make things work for myself since then.

In my opinion the PR wasn't handled properly, but I

  • [x] Allow edits by maintainers

so they are free to resolve the conflicts and merge this into the new version if the issue still exists.

martin-braun avatar Feb 26 '25 19:02 martin-braun

Hi 👋 ,

is this still an issue in Capacitor@7? We haven't upgraded yet, that's why I am asking. Thanks for your help.

natterstefan avatar Apr 23 '25 18:04 natterstefan

For those asking about Capacitor 7, yes it's still an issue. I've just come into Capacitor and found this PR and related issue after trying to diagnose why my external pages weren't getting a bridge. Would love to see this get some attention and merged.

RoystonS avatar Apr 26 '25 11:04 RoystonS