feat(browser): Add close() method for android #2

[PH-Lars]

Fixes for earlyer pull #151. Added the requested imports and added call to resolve so the promise will resolve.

[yaberkane05]

any news on this ?

[mfradcourt]

Are you sure this is working properly ? Tried your lines but it doesn't close the window :(

[holygekko]

Works like a charm for me, don't forget to clean your project in android studio so the new code gets build.

[danielehrhardt]

Please merge

[cardacci]

It would be great if this PR could be completed! Who should we reach out to for approval? Perhaps some of the most active collaborators know who to contact for this @jcesarmobile @imhoffd @theproducer

[cardacci]

It would be great if this PR could be completed! Who should we reach out to for approval? Perhaps some of the most active collaborators know who to contact for this.

[giralte-ionic]

@PH-Lars could you please merge with main

[giralte-ionic]

@PH-Lars please fix your linting errors and rebase with main

[NinaDenisova]

I am using capacitor plugin and the lack of close() prevents me from addressing an issue in the software I am working on. It looks like the changes of the PR are working, are in general accepted by the reviewer and only a finalization step is left. Do you happen to have any idea when this will finally be merged?

[ManuelOverdijk]

I've tested this PR:

• Works as expected on an Android Simulator, API 33
• Does not work on a real device, API 29

[cparkinsonMYCM]

I've tested this PR:

• Works as expected on an Android Simulator, API 33
• Does not work on a real device, API 29

That's absolutely fine, considering the current state is that it also doesn't work as it is isn't implemented.

[tfullerMYCM]

I've tested this PR on a real device running API 30 and it works as excepted.

I don't have a real device with API 29 so cannot test but as API 29 relates to Android 10 and that version no longer receives security updates this is not an issue for us as we will target API v. >=30

[sommmen]

Hi, @giralte-ionic could you take a look at this issue, i have a login with teams button which works in web, but on native it does not because of this issue.

[giralte-ionic]

@PH-Lars and/or @sommmen would it be possible to provide a test repo?

We're also concerned about this not working in API < 30 - the code should provide an API-version based escape route with proper error messaging

[maxcodefaster]

@PH-Lars and/or @sommmen would it be possible to provide a test repo?

We're also concerned about this not working in API < 30 - the code should provide an API-version based escape route with proper error messaging

Any updates? As far as I understand, it is basically done, except for an api version check. Looking through the issues, you can see that this pr is eagerly awaited.

[ItsChaceD]

This solution overrides the current activity stack and may not close the custom tabs depending on the context that the activity was launched as. I opened #1972 to circumvent this