capacitor-docs icon indicating copy to clipboard operation
capacitor-docs copied to clipboard

Add v3 to v4 plugin migration page

Open dotNetkow opened this issue 3 years ago • 4 comments

dotNetkow avatar Dec 01 '22 19:12 dotNetkow

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
capacitor-docs ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 7:34PM (UTC)

vercel[bot] avatar Dec 01 '22 19:12 vercel[bot]

Why are you removing the updating to 3.x guide? I think it can still be helpful and we are keeping the older upgrade guides for capacitor, so I think we should keep the old upgrade guides for plugins too.

That's true, definitely should keep those around. The PR makes it look like I deleted it entirely but I only removed from the current v4 Capacitor docs root level. Essentially it's replaced with the new v4 page (docs/updating/plugins/4-0). The 3.x guide still lives under /docs/v3/updating/plugins/3-0.

You have missed the podspec change, which is the most important one related to the iOS deployment target as the podspec is what's used when users install the plugin in their project ionic-team/create-capacitor-plugin@03027bf#diff-dc8721a872ae0dcc9e412a0a0b13bc684f6b8de82abee362ce965cf6d216f2d4L14

OK, updated the PR. see if it's correct now.

dotNetkow avatar Dec 05 '22 17:12 dotNetkow

That's true, definitely should keep those around. The PR makes it look like I deleted it entirely but I only removed from the current v4 Capacitor docs root level. Essentially it's replaced with the new v4 page (docs/updating/plugins/4-0). The 3.x guide still lives under /docs/v3/updating/plugins/3-0.

I know the docs are still on the v3 version of the docs, but I think we should keep the plugin update to version 3 file on the main docs too as we are doing with the updating app docs. That, or delete the old Updating to 1.1, 2.0 and 3.0 from the main menu if we only want to have the latest information and make users search for the older updating guides.

jcesarmobile avatar Dec 05 '22 18:12 jcesarmobile

OK, added v3 back in. Here's the root (v4) docs now: image

dotNetkow avatar Dec 16 '22 19:12 dotNetkow