capacitor-assets icon indicating copy to clipboard operation
capacitor-assets copied to clipboard

[bug:] cordova-res android --skip-config --copy is not working as expected

Open Sampath-Lokuge opened this issue 4 years ago • 6 comments

Hi,

npm install -g cordova-res

cordova-res android --skip-config --copy

Generated 18 resources for Android WARN: Error occurred while copying resources\android\icon\mdpi-foreground.png
WARN: Error occurred while copying resources\android\icon\hdpi-foreground.png
WARN: Error occurred while copying resources\android\icon\xhdpi-foreground.png
WARN: Error occurred while copying resources\android\icon\xxhdpi-foreground.png WARN: Error occurred while copying resources\android\icon\xxxhdpi-foreground.png Copied 26 resource items to Android

It works well with Splash. But it never replaces the default capacitor icons on the Android folder. i.e. it doesn't show the generated app icons. always shows the capacitor default icon.

1

Any clue here?

Ionic:

Ionic CLI : 6.11.11 (C:\Users\Sampath\AppData\Roaming\npm\node_modules@ionic\cli) Ionic Framework : @ionic/angular 5.3.3 @angular-devkit/build-angular : 0.1002.0 @angular-devkit/schematics : 10.2.0 @angular/cli : 10.1.2 @ionic/angular-toolkit : 2.3.3

Capacitor:

Capacitor CLI : 2.4.1 @capacitor/core : 2.4.2

Utility:

cordova-res : 0.15.2 native-run : 1.2.1

System:

NodeJS : v12.13.1 (C:\Program Files\nodejs\node.exe) npm : 6.12.1 OS : Windows 10

package.json

{ "name": "d", "version": "1.0.0", "author": "d", "homepage": "https://ionicframework.com/", "scripts": { "ng": "ng", "start": "ng serve", "build": "ng build", "lint": "ng lint" }, "private": true, "dependencies": { "@angular/common": "10.1.2", "@angular/core": "10.1.2", "@angular/fire": "6.0.4", "@angular/forms": "10.1.2", "@angular/google-maps": "10.2.6", "@angular/platform-browser": "10.1.2", "@angular/platform-browser-dynamic": "10.1.2", "@angular/router": "10.1.2", "@capacitor/android": "2.4.2", "@capacitor/core": "2.4.2", "@ionic-native/call-number": "5.29.0", "@ionic-native/core": "5.0.0", "@ionic-native/screen-orientation": "5.28.0", "@ionic/angular": "5.3.3", "call-number": "1.0.1", "cordova-plugin-screen-orientation": "3.0.2", "es6-promise-plugin": "4.2.2", "firebase": "8.0.1", "rxjs": "6.5.5", "tslib": "2.0.0", "zone.js": "0.10.3" }, "devDependencies": { "@angular-devkit/architect": ">= 0.900 < 0.1100", "@angular-devkit/build-angular": "0.1002.0", "@angular/cli": "10.1.2", "@angular/compiler": "10.1.2", "@angular/compiler-cli": "10.1.2", "@angular/language-service": "10.1.2", "@capacitor/cli": "2.4.1", "@ionic/angular-toolkit": "^2.3.3", "@types/node": "12.11.1", "codelyzer": "6.0.0", "firebase-tools": "8.0.0", "fuzzy": "0.1.3", "inquirer": "6.2.2", "inquirer-autocomplete-prompt": "1.0.1", "open": "7.0.3", "ts-node": "8.3.0", "tslint": "6.1.0", "typescript": "3.9.5" }, "description": "d" }

Sampath-Lokuge avatar Nov 11 '20 17:11 Sampath-Lokuge

Hi, @dwieeb Any feedback here?

Sampath-Lokuge avatar Nov 14 '20 16:11 Sampath-Lokuge

You may need to add adaptive icons:

https://github.com/ionic-team/cordova-res/issues/164

agriboss avatar Nov 18 '20 18:11 agriboss

Still facing the issue

lukasrybacki avatar Feb 25 '21 14:02 lukasrybacki

I'm a new user since today. I found the same issue. It is related to the adaptive icons. If you do not prepare your resources/android folder for adaptive icons, the default adaptive icons will remain in place. You will need to place adaptive icons in your project to override all icons properly. It's not a bug, just a feature.

Perhaps, to prevent confusion, this module could perform a cleanup of the existing images first?

ultimate-tester avatar May 03 '21 15:05 ultimate-tester

Same issue here, can anyone suggest a fix?

KasTasElis avatar Jul 15 '21 08:07 KasTasElis

I thought something was wrong, but it was because I didn't read the documentation: https://github.com/ionic-team/capacitor-assets#adaptive-icons

Danbardo avatar Dec 30 '21 01:12 Danbardo

Cordova support dropped in @capacitor/assets. Closing...

mlynch avatar Oct 02 '22 21:10 mlynch