angular-toolkit icon indicating copy to clipboard operation
angular-toolkit copied to clipboard

Published 20 hours ago • verified publisher icon ionic-team

refactor(schematics): extend from @schematics/angular at top level

Open jonz94 opened this issue 2 years ago • 1 comments

This PR simplify the structure of collection.json.

By doing so, we no longer need to worry about upstream's @schematics/angular changing their schematics name (which cause issues, like #470) or adding a new one (no need to manually add new schematic, like #461)

Closes #470

jonz94 avatar Oct 02 '22 00:10 jonz94

Hello! Just getting to this. Glad to see there's a way to go forward with this, considering the extend key didn't exist in previous versions of angular. I'll do a quick test to verify, but this should be good to go.

mhartington avatar Oct 17 '22 14:10 mhartington

I'm going to close this PR because the fix was already merged in #484. (Thank you, Mike 😄)

Upgrade the @ionic/angular-toolkit package to the latest version should be able to fix issues like #470 and https://github.com/ionic-team/ionic-cli/issues/4922

jonz94 avatar Apr 05 '23 10:04 jonz94