python-manhole icon indicating copy to clipboard operation
python-manhole copied to clipboard

"manhole-cli" can NOT connect when we use "socket_path" in the server

Open jcea opened this issue 7 years ago • 2 comments

"manhole-cli" requires a PID to connect. This doesn't work when the manhole server uses a specified name. "manhole-cli" REQUIRES the parameter to be a number or "/tmp/manhole-NUMBER". Also, "NUMBER" is used to send signals.

So, in order to use "manhole-cli":

  1. We can not use arbitrary names in the unix socket name.
  2. The unix socket MUST be in "/tmp/".
  3. If we relax the regexp in "manhole-cli" to be able to use arbitrary unix socket names, we can not send signals to the process.

jcea avatar Dec 15 '17 21:12 jcea

I guess we could have a new optional --path argument?

ionelmc avatar Dec 15 '17 22:12 ionelmc

Relaxed the regex to ^.+(/manhole-)?(?P<pid>\d+)$ for now. Will be in the next release (1.7.0).

ionelmc avatar Mar 20 '21 12:03 ionelmc