pytest-benchmark icon indicating copy to clipboard operation
pytest-benchmark copied to clipboard

Python 3.11 compatibility

Open danigm opened this issue 2 years ago • 5 comments

This patch adds the new arguments to the types.CodeType class constructor in the clonefunc function.

See https://github.com/ionelmc/pytest-benchmark/issues/231

danigm avatar Jan 17 '23 12:01 danigm

Codecov Report

Patch coverage: 60.00% and project coverage change: +0.01 :tada:

Comparison is base (7ef2645) 64.41% compared to head (254edb6) 64.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   64.41%   64.43%   +0.01%     
==========================================
  Files          29       29              
  Lines        2858     2862       +4     
  Branches      386      469      +83     
==========================================
+ Hits         1841     1844       +3     
- Misses        927      928       +1     
  Partials       90       90              
Impacted Files Coverage Δ
src/pytest_benchmark/compat.py 0.00% <0.00%> (ø)
tests/test_benchmark.py 100.00% <ø> (ø)
src/pytest_benchmark/utils.py 41.60% <75.00%> (+0.41%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jan 17 '23 16:01 codecov[bot]

.github workflows, etc, needs to be updated.

ngie-eign avatar Mar 12 '23 21:03 ngie-eign

I updated setup.py and CHANGELOG.rst in #237 as well. I think that's everything that needs to be done. I can close my PR in favor of your's.

ngie-eign avatar Mar 13 '23 07:03 ngie-eign

LGTM -- but I'm not a contributor, so sorry -- can't provide approval 😅 .

ngie-eign avatar Mar 13 '23 08:03 ngie-eign

PS You might need to rebase if you haven't done so recently, since this was originally based on sources from 2 months ago. I wouldn't do anything about that unless it's absolutely needed, or the maintainers ask.

ngie-eign avatar Mar 13 '23 08:03 ngie-eign