pytest-benchmark icon indicating copy to clipboard operation
pytest-benchmark copied to clipboard

add S3Storage

Open vincentsarago opened this issue 5 years ago • 6 comments

closes #160

To Do

  • [x] write tests

cc @ionelmc

vincentsarago avatar Feb 05 '20 21:02 vincentsarago

Codecov Report

Merging #161 into master will decrease coverage by 35.26%. The diff coverage is 13.95%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #161       +/-   ##
===========================================
- Coverage    67.8%   32.53%   -35.27%     
===========================================
  Files          16       17        +1     
  Lines        1792     1918      +126     
  Branches      317      340       +23     
===========================================
- Hits         1215      624      -591     
- Misses        497     1261      +764     
+ Partials       80       33       -47
Impacted Files Coverage Δ
src/pytest_benchmark/storage/s3.py 13% <13%> (ø)
src/pytest_benchmark/utils.py 37.21% <33.33%> (-29.38%) :arrow_down:
src/pytest_benchmark/table.py 15.18% <0%> (-74.69%) :arrow_down:
src/pytest_benchmark/fixture.py 15.92% <0%> (-65.93%) :arrow_down:
src/pytest_benchmark/timers.py 32.25% <0%> (-61.3%) :arrow_down:
src/pytest_benchmark/histogram.py 26.92% <0%> (-51.93%) :arrow_down:
src/pytest_benchmark/storage/file.py 25.49% <0%> (-41.18%) :arrow_down:
src/pytest_benchmark/stats.py 36.2% <0%> (-38.51%) :arrow_down:
src/pytest_benchmark/session.py 35.22% <0%> (-37.11%) :arrow_down:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dafa578...be6e000. Read the comment docs.

codecov-io avatar Mar 23 '20 02:03 codecov-io

@ionelmc Sorry about the failing tests 🤦‍♂ hope the last commit will pass 🤞

vincentsarago avatar Mar 23 '20 13:03 vincentsarago

Woaa, until yesterday I didn't know about iSort ... and now I understand why the tests were failling. Sorry about this @ionelmc . I hope it will be fine now

vincentsarago avatar Apr 16 '20 18:04 vincentsarago

@vincentsarago Is this something still in the works? We are evaluating using pytest benchmark and having S3 storage would be a great pro.

ncclementi avatar Jun 27 '22 16:06 ncclementi

@ncclementi it worked when I worked on this PR 😄 I haven't used it in a while so if there has been any update on the library this PR may need some update

vincentsarago avatar Jun 27 '22 17:06 vincentsarago

@vincentsarago Yes, I noticed the branch has conflicts, but I'm not sure what's the maintainer's intention in getting this implemented. The PR seems to be very close to done, but it's been a while. Maybe @ionelmc can comment on it?

ncclementi avatar Jun 27 '22 17:06 ncclementi