tlsdate icon indicating copy to clipboard operation
tlsdate copied to clipboard

Enable few more architectures

Open hrw opened this issue 9 years ago • 12 comments

To get tlsdate built in Fedora we need support for all secondary architectures (AArch64, POWER, s/390).

Additionally had to mark open() system call as optional as it is deprecated one so does not exists on AArch64. openat() should be used instead.

hrw avatar Feb 18 '16 12:02 hrw

Debian already reports that this is building on s/390:

https://buildd.debian.org/status/package.php?p=tlsdate&suite=jessie

Is there a similar page for Fedora?

I'm happy to merge in any case.

ioerror avatar Feb 18 '16 13:02 ioerror

Oh, S/390 lacks seccomp_filter in kernel so it builds without my patch. Similar with POWER.

Heh, I wanted to be nice to them ;D

I got info that POWER checks need to be changed a bit but that can be done on top of it (will provide patch).

hrw avatar Feb 18 '16 13:02 hrw

Fedora build infrastructure is split into primary architectures (x86, x86-64, arm) at http://koji.fedoraproject.org/ and secondary ones:

  • aarch64 http://arm.koji.fedoraproject.org/
  • POWER http://ppc.koji.fedoraproject.org/
  • S/390 http://s390.koji.fedoraproject.org/

Looks like we run newer kernels on builders than Debian does as s/390 under Fedora has seccomp_filter support in kernel.

hrw avatar Feb 18 '16 13:02 hrw

Can you confirm that tlsdate works on these platforms with your patch and that it did not before your patch? Have you used it?

ioerror avatar Feb 18 '16 14:02 ioerror

No, was not even aware of it's existence.

It failed to build on aarch64 so landed on my plate as "thing to fix". So I did. And then got asked "can you do POWER and S/390 while you are at this?" So I did.

Can check tlsdate on all those platforms next week.

hrw avatar Feb 18 '16 20:02 hrw

s/390x: does not compile without patch, works after:

[mjuszkie@devel6 tlsdate-tlsdate-0.0.13]$ ./A/bin/tlsdate -V Wed Feb 24 07:23:13 EST 2016 setting time failed: Operation not permitted (Difference from server is about -27 s)

Same on s/390 architecture.

On both ppc64 and ppc64le it compiles and works without patch (but also with patch).

hrw avatar Feb 24 '16 13:02 hrw

Great - thank you!

Could you update your change set to update the changelog to reflect all of your changes?

ioerror avatar Feb 24 '16 13:02 ioerror

updated

hrw avatar Feb 24 '16 13:02 hrw

ping?

hrw avatar Mar 17 '16 19:03 hrw

I can confirm that two of these patches are necessary for a successful build on aarch64. ( For ChromiumOS with a 64bit userspace).

ED6E0F17 avatar Jun 15 '16 23:06 ED6E0F17

ping?

hrw avatar Oct 28 '16 21:10 hrw

ping?

cfriedt avatar Nov 28 '16 18:11 cfriedt