tlsdate icon indicating copy to clipboard operation
tlsdate copied to clipboard

fixing some systemd configs

Open joelanders opened this issue 10 years ago • 4 comments

  1. I removed the curly-brackets from the tlsdated.service file because otherwise DAEMON_OPTS="-f some/file" ends up getting sent to tlsdated as one argument instead of two. (and DAEMON_OPTS="" is interpreted as one argument instead of zero.)

  2. I copy the /etc/default/tlsdated file to where it's being expected, because otherwise systemd throws an error when it looks for EnvironmentFile.

Never done any debian packaging, so the style's probably off. Probably the .service and .default file should be moved in the Makefile, since they're in upstream tlsdate now?

joelanders avatar Nov 18 '14 01:11 joelanders

LGTM

kartikm avatar Nov 18 '14 04:11 kartikm

I'd like to see what @h01ger thinks of these changes?

ioerror avatar Jan 05 '15 12:01 ioerror

I think that the changes in the systemd service file should be merged asap. The presence of the brackets cause the daemon to fail to set the time. The error in the logs is

Apr 17 09:28:47 helda tlsdated[1770]: initial time sync type: system-clock
Apr 17 09:28:47 helda tlsdated[1770]: synced rtc to sysclock
Apr 17 09:28:47 helda tlsdated[1770]: [event:handle_time_setter] time set from the system-clock (1429255727)
Apr 17 09:28:47 helda tlsdated[1770]: [tlsdate-monitor] execve() failed: No such file or directory
Apr 17 09:29:07 helda tlsdated[1770]: [tlsdate-monitor] execve() failed: No such file or directory
Apr 17 09:29:07 helda tlsdated[1775]: [tlsdate-monitor] execve() failed: No such file or directory
Apr 17 09:29:47 helda tlsdated[1770]: [tlsdate-monitor] execve() failed: No such file or directory
Apr 17 09:29:47 helda tlsdated[1800]: [tlsdate-monitor] execve() failed: No such file or directory

I observed this on Gentoo (see Gentoo bug 533380), but I think this might be the same on Debian's bug 778776

dkriegner avatar Apr 17 '15 07:04 dkriegner

This fixed my issue as well on Raspbian. Why hasn't this been merged and the issue closed?

ghost avatar Nov 07 '16 20:11 ghost